[Bug 34316] UpdateParameters: bad handling of DBus_Property and Has_Default in Unset argument

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34316

Danielle Madeley <danielle.madeley at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #6 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-02-20 17:40:41 PST ---
I like this. One niggle to prove I really read it:

+    if (!check_parameters (account, protocol, params, unset, dbus_properties,
+                           not_yet, &error))
+    {
+        g_hash_table_unref (dbus_properties);
+        g_ptr_array_unref (not_yet);
+        goto error;

+    g_hash_table_unref (dbus_properties);
+    g_ptr_array_unref (not_yet);
     tp_connection_manager_protocol_free (protocol);
     return;

It might be nice to have goto finally; and then error: then finally: so that
all the memory is released in one location -- since my first question was
whether or not the error path free'd @protocol.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.