[Bug 37844] Don't try to reconnect an account over and over for certain errors

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37844

Emilio Pozuelo Monfort <pochu27 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pochu27 at gmail.com

--- Comment #2 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-06-15 00:13:36 PDT ---
(In reply to comment #1)
> Does MC actually reconnect on that error? Last time I looked, it had a
> whitelist of errors that might potentially be addressed by reconnecting, and
> would not reconnect on other errors.

You are right. That is in mcd-connection.c:mcd_connection_invalidated_cb()

    if ((priv->abort_reason == TP_CONNECTION_STATUS_REASON_NONE_SPECIFIED ||
         priv->abort_reason == TP_CONNECTION_STATUS_REASON_NETWORK_ERROR) &&
        priv->probation_drop_count <= PROBATION_MAX_DROPPED)
    {
        /* we were disconnected by a network error or by a connection manager
         * crash (in the latter case, we get NoneSpecified as a reason): don't
         * abort the connection but try to reconnect later */

The problem is that there doesn't seem to be a
TP_CONNECTION_STATUS_REASON_UPGRADE_SOFTWARE_REQUIRED, and so CMs may use
_NETWORK_ERROR (for the lack of a more appropriate/specific reason), and so MC
tries to reconnect. So the question is, should there be more
TP_CONNECTION_STATUS_REASON_*, should CMs use another one for this error, or
anything else, like e.g. MC should check dbus_reason too?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.