[Bug 37844] Don't try to reconnect an account over and over for certain errors

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37844

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-06-15 02:17:57 PDT ---
(In reply to comment #2)
> The problem is that there doesn't seem to be a
> TP_CONNECTION_STATUS_REASON_UPGRADE_SOFTWARE_REQUIRED, and so CMs may use
> _NETWORK_ERROR (for the lack of a more appropriate/specific reason)

Indeed, errors.xml says Network_Error is the generic form of
SoftwareUpdateRequired. (I'm not convinced that's right - if there isn't a
better enum member, it should be Not_Specified - but that wouldn't help us here
because MC treats those two the same.)

> tries to reconnect. So the question is, should there be more
> TP_CONNECTION_STATUS_REASON_*, should CMs use another one for this error, or
> anything else, like e.g. MC should check dbus_reason too?

Ideally, MC should base its behaviour on the GError in
TpConnection::invalidated (which is derived from the dbus_reason, or from the
enum member if we don't understand the dbus_reason), falling back to
tp_connection_get_status() if it doesn't understand the GError.

This would give it a reliable way to detect CM crashes
(TP_DBUS_ERROR_NAME_OWNER_LOST, I believe?).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.