[Bug 48544] replace bitfields with flags or separate booleans as appropriate

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Apr 11 18:11:07 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=48544

--- Comment #1 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2012-04-11 09:11:07 PDT ---
(In reply to comment #0)
> This:
> 
> > > +  unsigned had_weak_object:1;
> 
> is pretty ugly.
> 
> Where booleans make most sense, we should use "gboolean had_weak_object;" and
> just accept the extra memory. We don't necessarily even need to wait for next;
> we can do this in master.

Yes yes yes!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list