[Bug 44649] Gabble plugin API symbols should be factored out to a separate library

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jan 11 08:41:53 CET 2012


https://bugs.freedesktop.org/show_bug.cgi?id=44649

--- Comment #4 from Olli Salli <ollisal at gmail.com> 2012-01-10 23:41:53 PST ---
You must also move individual symbols such as this one to separate files, not
just try to pick existing files to each lib.

Something like connection-plugins.c might be a sensible target in this case.

When moving definitions between source files, you'll also occasionally need to
forward declare more stuff they need in internal headers, but that's fine.

Gabble maintainers, any comments?On 11.1.2012 2:36
bugzilla-daemon at freedesktop.org wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=44649

--- Comment #3 from Siraj Razick <siraj.razick at collabora.co.uk> 2012-01-11
02:36:16 EET ---
(In reply to comment #2)
> See also bug 44331, comments 3-5 for background
>
> Removing patch keyword from here. There's no reviewable patch yet :)

I"m facing a big problem, plugins depend on gabble_connection_get_type() of
connection.c, and if I include connection.c the symbols in this file refers to
every other file in the source tree so to include connection.c, I must add all
the other files in the source tree.

Any ideas how I can solve this issue ?

--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.



More information about the telepathy-bugs mailing list