[Bug 44649] Gabble plugin API symbols should be factored out to a separate library

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=44649

--- Comment #5 from Siraj Razick <siraj.razick at collabora.co.uk> 2012-01-11 11:09:29 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > See also bug 44331, comments 3-5 for background
> > 
> > Removing patch keyword from here. There's no reviewable patch yet :)
> 
> I"m facing a big problem, plugins depend on gabble_connection_get_type() of
> connection.c, and if I include connection.c the symbols in this file refers to
> every other file in the source tree so to include connection.c, I must add all
> the other files in the source tree.
> 
> Any ideas how I can solve this issue ?

(In reply to comment #4)
> You must also move individual symbols such as this one to separate files, not
> just try to pick existing files to each lib.
> 
> Something like connection-plugins.c might be a sensible target in this case.
> 

I had a discussion with Oggis on irc about this, it's not really easy to factor
out gabble_connection_get_type() into
different files.  And currently the connection is a property of the plugins  So
oggis proposed that it could be solved by having a GabbleSidecarManager which
will hand over the GabbleConnections to plugins and there wouldn't be a
gabble/connection.h with the update_sidecar_capabilities, add_sidecar_own_caps
functions, but some gabble/sidecar-manager.h declaring those

Any comments or idea's about this approach ?  We are also wondering if there
any other workaround which we can do without needing to change the plugin API
again .

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.