[PATCH] drm-backend: for now, on the egl backend, force gl cursors to be used instead of hardware cursors

[Pekka Paalanen]

On Mon, 18 May 2015 22:10:27 -0400
nerdopolis <bluescreen_avenger at verizon.net> wrote:

> Hardware cursors have been causing some problems with some drivers, mostly i915
> 
> This will probably be changed once Atomic Mode Setting arrives, to probably only force gl cursors
> to always be on when Atomic Mode Setting isn't supported by the driver, or kernel version
> ---
>  src/compositor-drm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/compositor-drm.c b/src/compositor-drm.c
> index 0cdb8f4..0636a37 100644
> --- a/src/compositor-drm.c
> +++ b/src/compositor-drm.c
> @@ -1641,6 +1641,9 @@ drm_output_init_egl(struct drm_output *output, struct drm_compositor *ec)
>  		weston_log("cursor buffers unavailable, using gl cursors\n");
>  		ec->cursors_are_broken = 1;
>  	}
> +	/* TODO Remove when atomic mode setting is merged into the mainline kernel, and detect if the
> +	 * running kernel supports atomic mode setting instead. */
> +	ec->cursors_are_broken = 1;
>  
>  	return 0;
>  }

Hi,

I think this is the wrong place to set this, we need it also for the
Pixman path. It should just be set in the same place we set
sprites_are_broken.

There is also quite a lot more background info I would like to record
with this commit, so I went ahead and just rewrote this patch. I will
be sending it to the list right now.


Thanks,
pq