[PATCH] drm-backend: for now, on the egl backend, force gl cursors to be used instead of hardware cursors

Daniel Vetter daniel at ffwll.ch
Wed May 20 00:04:52 PDT 2015


On Mon, May 18, 2015 at 10:10:27PM -0400, nerdopolis wrote:
> Hardware cursors have been causing some problems with some drivers, mostly i915

What exactly goes wrong with cursor on i915? Working around kernel bugs in
userspace is imo bad since it'll perpetuate the bug ...
-Daniel

> 
> This will probably be changed once Atomic Mode Setting arrives, to probably only force gl cursors
> to always be on when Atomic Mode Setting isn't supported by the driver, or kernel version
> ---
>  src/compositor-drm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/compositor-drm.c b/src/compositor-drm.c
> index 0cdb8f4..0636a37 100644
> --- a/src/compositor-drm.c
> +++ b/src/compositor-drm.c
> @@ -1641,6 +1641,9 @@ drm_output_init_egl(struct drm_output *output, struct drm_compositor *ec)
>  		weston_log("cursor buffers unavailable, using gl cursors\n");
>  		ec->cursors_are_broken = 1;
>  	}
> +	/* TODO Remove when atomic mode setting is merged into the mainline kernel, and detect if the
> +	 * running kernel supports atomic mode setting instead. */
> +	ec->cursors_are_broken = 1;
>  
>  	return 0;
>  }
> -- 
> 2.1.0
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the wayland-devel mailing list