[Xcb] Win32 branch of XCB now up :)

[Jeetu Golani]

Hi Peter,

Thanks for getting back :)

> 1) fprintf(stderr, is not permitted inside libxcb. I know, it's a pain
> when error codes get lost, but it's even worse when a library stomps on
> the app's output handles.

This worried me too but when I was porting based on one of your earlier 
releases a grep showed up an fprintf in the file xcb_xlib.c, therefore I 
thought it was acceptable within the code for some reason and I kept it on. I 
can't seem to fine xcb_xlib.c in the current release anymore nor any further 
fprintf statements, so I'll take this off.

> 2) I prefer #ifdef _WIN32 (defined by the compiler) over #ifdef WIN32
> (defined by the makefile). But that's just my personal preference, not
> official policy or anything.

I don't mind changing this. Would appreciate if you could explain the 
rationale behind this from a purely informative perspective.

Will make the changes when I have a lil more time to test out the code n 
stuff. Also need to make a change which Duy had suggested earlier. For now I 
wanna get xcb-util to work under win32. I've got all the other libraries in 
there to build other than the image library and this is what I was most 
interested in to begin with ironically ;) haha :)

Bye for now



On Tuesday 12 May 2009, Peter Harris wrote:
> Jeetu Golani wrote:
> > Hi guys,
> >
> > I've updated my branch at github to reflect changes in code as suggested
> > by Julien and also rectify the goof ups I made with my initial
> > submission.
>
> Thanks, that looks much better.
>
> Sorry I do not have time to do a full review today, but two things stick
> out:
>
> 1) fprintf(stderr, is not permitted inside libxcb. I know, it's a pain
> when error codes get lost, but it's even worse when a library stomps on
> the app's output handles.
>
> 2) I prefer #ifdef _WIN32 (defined by the compiler) over #ifdef WIN32
> (defined by the makefile). But that's just my personal preference, not
> official policy or anything.
>
> Peter Harris



-------------------------------------------------------