[Xcb] Split up of xcb/util repository finally pushed
psychon at znc.in
Sun Mar 6 10:21:37 PST 2011
-----BEGIN PGP SIGNED MESSAGE-----
Am 06.03.2011 12:17, Arnaud Fontaine wrote:
> [...]I also merged all the code
> for EWMH which has already been reviewed on this mailing list. [...]
I took a closer at the new EWMH functions in util-wm and this surely does look
interesting. However, one thing made me wonder:
_NET_WM_ICON is an array of possible icons, that means it can contain more than
one icon. But all the xcb_ewmh_*_wm_icon* functions assume that it only contains
a single icon.
Also, xcb_ewmh_get_wm_icon_from_reply() only checks if the property value has at
least a length of 2. It doesn't check if this property really is large enough
for the icon that it claims to contain.
"Do you know that books smell like nutmeg or some spice from a foreign land?"
-- Faber in Fahrenheit 451
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Xcb