[Xcb] Split up of xcb/util repository finally pushed

Arnaud Fontaine arnaud at andesi.org
Sun Mar 6 19:13:02 PST 2011


Hi,

    > I  took a  closer at the  new EWMH  functions in util-wm  and this
    > surely does look interesting. However, one thing made me wonder:

    >  _NET_WM_ICON is an  array of  possible icons,  that means  it can
    >  contain  more than  one  icon.  But  all the  xcb_ewmh_*_wm_icon*
    > functions assume that it only contains a single icon.

    >   Also,  xcb_ewmh_get_wm_icon_from_reply()   only  checks  if  the
    > property  value has at  least a length  of 2. It doesn't  check if
    > this property  really is large enough for the  icon that it claims
    > to contain.

Yes, you're right,  my mistake ;). I will fix  that this evening. Please
let me  know if you see anything  else in the meantime.  Thanks for your
review.

Cheers,
--
Arnaud Fontaine


More information about the Xcb mailing list