[Xcb] [Bug 68387] xinput2 XIQueryDevice reply not read correctly

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=68387

--- Comment #3 from Ran Benita <ran234 at gmail.com> ---
Thanks for the patch Daniel.

So it seems this bug is pretty far-reaching; basically all of the _sizeof()
functions have it, though it only manifests on the ones which actually use
xcb_tmp for anything. So to see the affected functions, you can grep for the
pattern "(xcb_tmp)".

Most of them are _sizeof()'s of requests/events/errors, which no one cares
about I think. But some are used in iterators for _next() functions. The most
affected extensions are xkb and xinput, but also others. For example, I'm
pretty sure xcb_get_setup() is broken when there is more than one Screen
(roots_len > 1) - in this case the attached program should show garbage.

So, if you submit the patch with some commit message,
Tested-By: Ran Benita <ran234 at gmail.com>
Reviewed-By: Ran Benita <ran234 at gmail.com>
As the fix seems pretty obvious, fixes this test and doesn't cause any other
problems that I've seen.

And I also think this is ample demonstration that no one is using the _sizeof()
functions directly, and that they should therefore be static in the c files and
not exposed in the headers; I also think this will reduce the extension library
sizes substantially due to dead code elimination.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130822/366191bf/attachment.html>