[Xcb] State of XInputExtension

[Christian Linhart]

Hi Peter,

Thank you for your info about the relevant changes in the spec.
Good to hear that there weren't any relevant changes since I cross-checked the spec with the xml.

The typoe that you mentioned is not relevant for the xinput.xml because the mask is directly defined there, without an intermediate constant:
https://cgit.freedesktop.org/xcb/proto/tree/src/xinput.xml?id=97fbba25baf241cbcda882739db423b1d36e440a#n1577

So, this looks good.

Cheers,

Chris


On 2017-03-12 23:26, Peter Hutterer wrote:
> On Sat, Mar 11, 2017 at 01:27:50PM +0100, Christian Linhart wrote:
>> Hi Uli,
>>
>> I think that XINPUT-support in XCB is complete now, with the changes that I have pushed today.
>> However, I'd like to get at least one second opinion on that before we enable it by default.
> ah, that's great to hear, thanks!
>
>> Especially, the newest changes in
>> https://cgit.freedesktop.org/xorg/proto/inputproto/
>> should be cross-checked with xinput.xml in xcb/proto.
>> Most of my changes are based on the state of the XINPUT-spec from 2014 or so.
> there haven't been any serious changes to the protocol since inputproto 2.3
> (March 2013), it was just spit and polish after that. The only one that
> could have an effect on xcb is 
> https://cgit.freedesktop.org/xorg/proto/inputproto/commit/?id=c2cf8cab4aa781306ff26b171107d26f12bac015
> but that one only if you managed to copy that typo :)
>
> Cheers,
>    Peter
>
>> Thank you for asking for a list of remaining issues:
>> There is such a list: it is in the comment at the beginning of xinput.xml.
>> I have forgotten about this list, and therefore forgotten to remove it.
>> I'll post a patch for that, soon.
>>
>> Cheers,
>>
>> Chris
>>
>> P.S.: I didn't realize that pthread_stubs is an extra library. :-)
>>
>> On 2017-03-11 12:19, Uli Schlachter wrote:
>>> Hi Christian,
>>>
>>> On 11.03.2017 11:58, Christian Linhart wrote:
>>>> When you prepare the release please update the version-dependency
>>>> between libxcb and proto.
>>>>
>>>> There is at least one change so that libxcb only builds when proto is up to date.
>>> I only plan to do a pthread-stubs release. No libxcb or xcb-proto
>>> release. But thanks for the pointer. :-)
>>>
>>>
>>> I'll switch the topic:
>>>
>>> Thanks for your work on the Input protocol. Sorry that I cannot help
>>> much there. However, I was wondering about: What is the state of XInput
>>> support in XCB? As far as I know, it is the only remaining extension
>>> that is of wider interest[1] and that is not enabled by default in XCB.
>>> Do we have a list of remaining issues or something like that?
>>>
>>> [1]: This seems to exclude Xprint and SELinux.
>>>
>>> Thanks!
>>>
>>> Cheers,
>>> Uli
>>>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/xcb