[Xcb] State of XInputExtension

[Christian Linhart]

Hi Bart,

Thank you for taking a look and for your feedback.
I agree with you to just enable XINPUT and see what happens.

I'll post a patch for this soon.

To the state of QA-testing:

You are probably right that nobody has the time to write a test-suite.
(Though this could be a good project for OPW. It won't matter if it'll be half-finished. Half a testsuite will already be useful.)

There has already been QA testing for the stuff in xcb/proto, i.e., xinput.xml and xcbgen:
This is in use with another generator in my commercial product.
I.e., the protocol definitions are tested to the extent which is relevant in my product.
So, we won't throw untested stuff to users.
It'll be more for the fine-tuning. :-)

For some of the changes in xinput I have written testcases for libxcb, e.g., for SendExtensionEvent.
Mostly to test new features that I have added to the generator.

Cheers,

Chris



On 2017-03-11 20:58, Bart Massey wrote:
> Speaking just for myself, I'm quite comfortable at this point with just enabling XINPUT and letting the chips fall where they may. The work seems at first glance to be excellently and professionally done. Enabling the changes almost certainly wouldn't leave things any worse than they are now with regard to XINPUT, and I am skeptical that there are breaking changes to the rest of XCB. A test suite would be nice, but I doubt anybody has the time and energy to write one: I know I don't. So I think let's do the "user testing" thing. But I'm not a maintainer anymore (except maybe of the image library), so it's definitely not my call...
>
> On Sat, Mar 11, 2017 at 9:05 AM Uli Schlachter <psychon at znc.in <mailto:psychon at znc.in>> wrote:
>
>     Hi Christian,
>
>     On 11.03.2017 13:27, Christian Linhart wrote:
>     > I think that XINPUT-support in XCB is complete now, with the changes that I have pushed today.
>     > However, I'd like to get at least one second opinion on that before we enable it by default.
>
>     Sounds good, thanks for the info. I do not feel qualified to give that
>     second opinion, sorry.
>
>     > Especially, the newest changes in
>     > https://cgit.freedesktop.org/xorg/proto/inputproto/
>     > should be cross-checked with xinput.xml in xcb/proto.
>     > Most of my changes are based on the state of the XINPUT-spec from 2014 or so.
>     [...]
>
>     At least the changes from 2016 and 2017 only touch autotools-files and
>     so are not relevant here...
>
>     Cheers,
>     Uli
>     --
>     If you have to type the letters "A-E-S" into your source code, you're
>     doing it wrong.
>     _______________________________________________
>     Xcb mailing list
>     Xcb at lists.freedesktop.org <mailto:Xcb at lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/xcb
>
>
>
> _______________________________________________
> Xcb mailing list
> Xcb at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/xcb