clang static analysis of xorg-server

Alan Coopersmith Alan.Coopersmith at Sun.COM
Tue Mar 23 06:45:00 PDT 2010


Matthias Hopf wrote:
> On Mar 22, 10 17:50:38 -0700, Jeremy Huddleston wrote:
>> Actually, it was a valid error.  The assignment was doing |= rather than =, 
>> and the current value was garbage.
> 
> ?  |= looks correct.

Jeremy's right though - the struct is allocated on the stack, uninitialized,
2 lines previous, and no value was set first so the |= is doing
cn.changedControls = (uninitalized) | XkbControlsEnabledMask;

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list