clang static analysis of xorg-server

[Matthias Hopf]

On Mar 23, 10 06:45:00 -0700, Alan Coopersmith wrote:
> Matthias Hopf wrote:
> > On Mar 22, 10 17:50:38 -0700, Jeremy Huddleston wrote:
> >> Actually, it was a valid error.  The assignment was doing |= rather than =, 
> >> and the current value was garbage.
> > ?  |= looks correct.
> 
> Jeremy's right though - the struct is allocated on the stack, uninitialized,
> 2 lines previous, and no value was set first so the |= is doing
> cn.changedControls = (uninitalized) | XkbControlsEnabledMask;

Eeek. Yes, overlooked that.

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de