xf86-video-savage: add missing xf86CrtcConfigInit in SavagePreInit
Alex Villacís Lasso
a_villacis at palosanto.com
Tue Jan 13 08:36:45 PST 2009
With the latest git for xserver and the latest git for savage, an
attempt to start up crashes the server unless this patch is applied. It
seems that an explicit xf86CrtcConfigInit() is now required in the
PreInit stage of the driver setup. I found via valgrind that the absence
of this call causes several invalid reads, but only the one triggered by
DRIFinishScreenInit() actually crashes the server on startup. Grepping
through the git code, only xf86-video-intel, xf86-video-ati,
xf86-video-nv and xf86-video-siliconmotion have this call in their code.
Does this mean that any other driver that tries to init DRI will crash
in the same way with latest xserver?
* Add missing xf86CrtcConfigInit in SavagePreInit. Fixes a crash on
startup with latest xserver git.
perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1563 bytes
Desc: not available
More information about the xorg