答复: [PATCH] Standardizing the info message for unimplemented functions

Wang, Ken Ken.Wang at amd.com
Mon Aug 8 02:35:43 UTC 2016


Reviewed-by: Ken Wang <Qingqing.Wang at amd.com>

________________________________
发件人: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> 代表 Alexandre Demers <alexandre.f.demers at gmail.com>
发送时间: 2016年8月8日 5:17:41
收件人: amd-gfx at lists.freedesktop.org
主题: [PATCH] Standardizing the info message for unimplemented functions

Signed-off-by: Alexandre Demers <alexandre.f.demers at gmail.com>

---
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
index 07e0475..9e327be 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
@@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] = {
 static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
                                      u32 block_offset, u32 reg)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
         return 0;
 }

 static void dce_v6_0_audio_endpt_wreg(struct amdgpu_device *adev,
                                       u32 block_offset, u32 reg, u32 v)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_endpt_wreg ----no impl!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_endpt_wreg --- not implemented!\n");
 }

 static bool dce_v6_0_is_in_vblank(struct amdgpu_device *adev, int crtc)
@@ -459,7 +459,7 @@ static u32 dce_v6_0_hpd_get_gpio_reg(struct amdgpu_device *adev)

 static bool dce_v6_0_is_display_hung(struct amdgpu_device *adev)
 {
-       DRM_INFO("xxxx: dce_v6_0_is_display_hung ----no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_is_display_hung --- not implemented!\n");

         return true;
 }
@@ -1321,17 +1321,17 @@ static void dce_v6_0_afmt_audio_select_pin(struct drm_encoder *encoder)
 static void dce_v6_0_audio_write_latency_fields(struct drm_encoder *encoder,
                                                 struct drm_display_mode *mode)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_write_latency_fields---no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_write_latency_fields --- not implemented!\n");
 }

 static void dce_v6_0_audio_write_speaker_allocation(struct drm_encoder *encoder)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_write_speaker_allocation---no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_write_speaker_allocation --- not implemented!\n");
 }

 static void dce_v6_0_audio_write_sad_regs(struct drm_encoder *encoder)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_write_sad_regs---no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_write_sad_regs --- not implemented!\n");

 }
 */
@@ -1339,7 +1339,7 @@ static void dce_v6_0_audio_enable(struct amdgpu_device *adev,
                                   struct amdgpu_audio_pin *pin,
                                   bool enable)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_enable---no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_enable --- not implemented!\n");
 }

 static const u32 pin_offsets[7] =
@@ -1376,12 +1376,12 @@ static void dce_v6_0_afmt_update_ACR(struct drm_encoder *encoder, uint32_t clock
 static void dce_v6_0_afmt_update_avi_infoframe(struct drm_encoder *encoder,
                                                void *buffer, size_t size)
 {
-       DRM_INFO("xxxx: dce_v6_0_afmt_update_avi_infoframe---no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_afmt_update_avi_infoframe --- not implemented!\n");
 }

 static void dce_v6_0_audio_set_dto(struct drm_encoder *encoder, u32 clock)
 {
-       DRM_INFO("xxxx: dce_v6_0_audio_set_dto---no imp!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_audio_set_dto --- not implemented!\n");
 }
 */
 /*
@@ -1390,7 +1390,7 @@ static void dce_v6_0_audio_set_dto(struct drm_encoder *encoder, u32 clock)
 static void dce_v6_0_afmt_setmode(struct drm_encoder *encoder,
                                   struct drm_display_mode *mode)
 {
-       DRM_INFO("xxxx: dce_v6_0_afmt_setmode ----no impl !!!!!!!!\n");
+       DRM_INFO("xxxx: dce_v6_0_afmt_setmode --- not implemented!\n");
 }

 static void dce_v6_0_afmt_enable(struct drm_encoder *encoder, bool enable)
@@ -2553,7 +2553,7 @@ static int dce_v6_0_wait_for_idle(void *handle)

 static int dce_v6_0_soft_reset(void *handle)
 {
-       DRM_INFO("xxxx: dce_v6_0_soft_reset --- no impl!!\n");
+       DRM_INFO("xxxx: dce_v6_0_soft_reset --- not implemented!\n");
         return 0;
 }

--
2.9.2

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160808/42acbfd1/attachment.html>


More information about the amd-gfx mailing list