[PATCH] Standardizing the info message for unimplemented functions

Huang Rui ray.huang at amd.com
Mon Aug 8 05:22:24 UTC 2016


On Sun, Aug 07, 2016 at 05:17:41PM -0400, Alexandre Demers wrote:
> Signed-off-by: Alexandre Demers <alexandre.f.demers at gmail.com>
> 
> ---
>  drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> index 07e0475..9e327be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
> @@ -106,14 +106,14 @@ static const uint32_t hpd_int_control_offsets[6] = {
>  static u32 dce_v6_0_audio_endpt_rreg(struct amdgpu_device *adev,
>  				     u32 block_offset, u32 reg)
>  {
> -	DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg ----no impl!!!!\n");
> +	DRM_INFO("xxxx: dce_v6_0_audio_endpt_rreg --- not implemented!\n");
>  	return 0;

We can make the code more simple like below:

DRM_INFO("xxxx: %s --- not implemented!\n", __func__);

Thanks,
Rui


More information about the amd-gfx mailing list