[PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails

Jay Cornwall jay at jcornwall.me
Wed Aug 10 16:49:07 UTC 2016


On 2016-08-10 11:10, Alex Deucher wrote:
> On Wed, Aug 3, 2016 at 2:39 PM, Jay Cornwall <jay at jcornwall.me> wrote:
>> fence_put was called on an uninitialized variable.
>> 
>> Signed-off-by: Jay Cornwall <jay at jcornwall.me>
> 
> Can you commit this internally or do you need one of us to?
> 
> Alex

I'm less familiar with the amdgpu branches. You could point me to the 
right one or commit this from your side.

>> ---
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> index b11f4e8..4aa993d 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> @@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring 
>> *ring, long timeout)
>>                 r = 0;
>>         }
>> 
>> -error:
>>         fence_put(fence);
>> +
>> +error:
>>         return r;
>>  }
>> --
>> 2.9.2
>> 
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-- 
Jay Cornwall


More information about the amd-gfx mailing list