[PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails

Deucher, Alexander Alexander.Deucher at amd.com
Wed Aug 10 17:27:32 UTC 2016


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Jay Cornwall
> Sent: Wednesday, August 10, 2016 12:49 PM
> To: Alex Deucher
> Cc: Kuehling, Felix; amd-gfx list
> Subject: Re: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
> 
> On 2016-08-10 11:10, Alex Deucher wrote:
> > On Wed, Aug 3, 2016 at 2:39 PM, Jay Cornwall <jay at jcornwall.me> wrote:
> >> fence_put was called on an uninitialized variable.
> >>
> >> Signed-off-by: Jay Cornwall <jay at jcornwall.me>
> >
> > Can you commit this internally or do you need one of us to?
> >
> > Alex
> 
> I'm less familiar with the amdgpu branches. You could point me to the
> right one or commit this from your side.

amd-staging-4.6

I'll commit this unless you beat me to it.

Alex

> 
> >> ---
> >>  drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> index b11f4e8..4aa993d 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> @@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct
> amdgpu_ring
> >> *ring, long timeout)
> >>                 r = 0;
> >>         }
> >>
> >> -error:
> >>         fence_put(fence);
> >> +
> >> +error:
> >>         return r;
> >>  }
> >> --
> >> 2.9.2
> >>
> >> _______________________________________________
> >> amd-gfx mailing list
> >> amd-gfx at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
> --
> Jay Cornwall
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list