cz smu cleanups

[Deucher, Alexander]

Yes.  We only need to call it once for STONEY.

From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of StDenis, Tom
Sent: Friday, August 26, 2016 12:38 PM
To: amd-gfx list
Subject: cz smu cleanups


Still on the topic of the smu code I see (in cz_smu_construct_toc_for_bootup())


cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);
if (smumgr->chip_id == CHIP_STONEY)
cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);
else
cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT2, false);


Which seems odd that it is loading twice for STONEY.  Shouldn't it just be != CHIP_STONEY and omit the first path?



Tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160826/9304ac74/attachment.html>