cz smu cleanups

StDenis, Tom Tom.StDenis at amd.com
Fri Aug 26 16:38:15 UTC 2016


Still on the topic of the smu code I see (in cz_smu_construct_toc_for_bootup())


cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);
if (smumgr->chip_id == CHIP_STONEY)
cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT1, false);
else
cz_smu_populate_single_ucode_load_task(smumgr,
CZ_SCRATCH_ENTRY_UCODE_ID_CP_MEC_JT2, false);


Which seems odd that it is loading twice for STONEY.  Shouldn't it just be != CHIP_STONEY and omit the first path?


Tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160826/d7667b97/attachment-0001.html>


More information about the amd-gfx mailing list