[PATCH 1/8] drivers/amdgpu: Remove spurious semicolons

[StDenis, Tom]

Entire series looks fine with the exception of patch #7 I'd remove the redundant parenthesis e.g.


-       if ((force_high == false) && (cz_ps->action == FORCE_HIGH))
+       if (!(force_high) && (cz_ps->action == FORCE_HIGH))

(and in various places).  With that

Reviewed-by: Tom St Denis <tom.stdenis at amd.com>.

The PP changes (patch #8) looks fine but I wonder if they had intended to put more error checking in at some point.

Tom

________________________________
From: Edward O'Callaghan <funfunctor at folklore1984.net>
Sent: Monday, July 11, 2016 03:11
To: amd-gfx at lists.freedesktop.org
Cc: StDenis, Tom; alexandre.f.demers at gmail.com
Subject: [PATCH 1/8] drivers/amdgpu: Remove spurious semicolons

Found-by: Coccinelle
Signed-off-by: Edward O'Callaghan <funfunctor at folklore1984.net>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
 drivers/gpu/drm/amd/amdgpu/fiji_smc.c       | 2 +-
 drivers/gpu/drm/amd/amdgpu/iceland_smc.c    | 2 +-
 drivers/gpu/drm/amd/amdgpu/tonga_smc.c      | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index b0832da..f518c10 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -122,7 +122,7 @@ static void amdgpu_flip_work_func(struct work_struct *__work)
                 spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
                 usleep_range(min_udelay, 2 * min_udelay);
                 spin_lock_irqsave(&crtc->dev->event_lock, flags);
-       };
+       }

         if (!repcnt)
                 DRM_DEBUG_DRIVER("Delay problem on crtc %d: min_udelay %d, "
diff --git a/drivers/gpu/drm/amd/amdgpu/fiji_smc.c b/drivers/gpu/drm/amd/amdgpu/fiji_smc.c
index b336c91..b3e19ba 100644
--- a/drivers/gpu/drm/amd/amdgpu/fiji_smc.c
+++ b/drivers/gpu/drm/amd/amdgpu/fiji_smc.c
@@ -173,7 +173,7 @@ static int fiji_send_msg_to_smc(struct amdgpu_device *adev, PPSMC_Msg msg)
 {
         if (!fiji_is_smc_ram_running(adev))
         {
-               return -EINVAL;;
+               return -EINVAL;
         }

         if (wait_smu_response(adev)) {
diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_smc.c b/drivers/gpu/drm/amd/amdgpu/iceland_smc.c
index 52ee081..7a0f0e6 100644
--- a/drivers/gpu/drm/amd/amdgpu/iceland_smc.c
+++ b/drivers/gpu/drm/amd/amdgpu/iceland_smc.c
@@ -211,7 +211,7 @@ static int iceland_send_msg_to_smc_without_waiting(struct amdgpu_device *adev,
                                                    PPSMC_Msg msg)
 {
         if (!iceland_is_smc_ram_running(adev))
-               return -EINVAL;;
+               return -EINVAL;

         if (wait_smu_response(adev)) {
                 DRM_ERROR("Failed to send previous message\n");
diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_smc.c b/drivers/gpu/drm/amd/amdgpu/tonga_smc.c
index 083893d..940de18 100644
--- a/drivers/gpu/drm/amd/amdgpu/tonga_smc.c
+++ b/drivers/gpu/drm/amd/amdgpu/tonga_smc.c
@@ -173,7 +173,7 @@ static int tonga_send_msg_to_smc(struct amdgpu_device *adev, PPSMC_Msg msg)
 {
         if (!tonga_is_smc_ram_running(adev))
         {
-               return -EINVAL;;
+               return -EINVAL;
         }

         if (wait_smu_response(adev)) {
--
2.7.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160711/84282900/attachment.html>