[PATCH 2/4] drm/amd/amdgpu: Add GFX and UVD PG for Carrizo

[Alex Deucher]

Just early engineering samples are rev0.

Alex

On Tue, Jul 26, 2016 at 2:49 PM, StDenis, Tom <Tom.StDenis at amd.com> wrote:

> I don't have rev0 hardware.  I can edit the comment but I can't test the
> switch to the logic.
>
>
> Is there even rev0 hardware in retail?
>
>
> Tom
>
>
> ------------------------------
> *From:* Alex Deucher <alexdeucher at gmail.com>
> *Sent:* Tuesday, July 26, 2016 14:47
> *To:* Tom St Denis
> *Cc:* amd-gfx list; StDenis, Tom
> *Subject:* Re: [PATCH 2/4] drm/amd/amdgpu: Add GFX and UVD PG for Carrizo
>
> On Tue, Jul 26, 2016 at 11:38 AM, Tom St Denis <tstdenis82 at gmail.com>
> wrote:
> > Enables GFX PG and UVD static PG on Carrizo class
> > asics.
> >
> > Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/vi.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c
> b/drivers/gpu/drm/amd/amdgpu/vi.c
> > index 9ba64989f092..289a4c4ac9e7 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> > @@ -1578,7 +1578,16 @@ static int vi_common_early_init(void *handle)
> >                         AMD_CG_SUPPORT_HDP_LS |
> >                         AMD_CG_SUPPORT_SDMA_MGCG |
> >                         AMD_CG_SUPPORT_SDMA_LS;
> > +               /* rev0 hardware doesn't support PG */
>
> It's probably worth correcting this comment.  A0 theoretically
> supports PG, but probably requires additional workarounds.  Something
> like "Don't enable PG on rev0 hw due to hw issues" or something like
> that.
>
> >                 adev->pg_flags = 0;
> > +               if (adev->rev_id != 0x00) {
> > +                       adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |
> > +                               AMD_PG_SUPPORT_GFX_SMG |
> > +                               AMD_PG_SUPPORT_GFX_PIPELINE;
> > +                       /* powerplay UVD PG doesn't work yet */
> > +                       if (!amdgpu_powerplay)
> > +                               adev->pg_flags |= AMD_PG_SUPPORT_UVD;
>
> It's probably worth testing UVD PG on rev0 hw as well so see if we can
> enable this on them as well.  OTOH, there isn't likely much rev0 hw in
> the wild, so it may not matter too much.
>
> Alex
>
> > +               }
> >                 adev->external_rev_id = adev->rev_id + 0x1;
> >                 break;
> >         case CHIP_STONEY:
> > --
> > 2.9.2
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> amd-gfx Info Page - lists.freedesktop.org
> <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
> lists.freedesktop.org
> To see the collection of prior postings to the list, visit the amd-gfx
> Archives. Using amd-gfx: To post a message to all the list members, send
> email ...
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160727/41be784c/attachment.html>