GFX bank selection in MMIO regs debugfs entry

[StDenis, Tom]

Yup I ended up adding instance to select_se_sh and then threw 0xFFFFFFFF all over gfx 7/8 as "broadcast".


I have 3 patches waiting review :-)


Tom


________________________________
From: Deucher, Alexander
Sent: Wednesday, June 29, 2016 09:43
To: StDenis, Tom; Nicolai Hähnle; amd-gfx list
Subject: RE: GFX bank selection in MMIO regs debugfs entry


You can just add instance as an argument.



Alex



From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of StDenis, Tom
Sent: Tuesday, June 28, 2016 9:52 AM
To: Nicolai Hähnle; amd-gfx list
Subject: Re: GFX bank selection in MMIO regs debugfs entry



Hi Nicolai,



Sure v2 of the patch could add that (this is why I haven't pushed the debugger changes either hehehe).



Is there an amdgpu_*() interface to select the instance?  Or should we submit a patch to augment select_se_sh?



Tom



________________________________

From: Nicolai Hähnle <nhaehnle at gmail.com<mailto:nhaehnle at gmail.com>>
Sent: Tuesday, June 28, 2016 08:54
To: StDenis, Tom; amd-gfx list
Subject: Re: GFX bank selection in MMIO regs debugfs entry



On 27.06.2016 18:32, StDenis, Tom wrote:
> This adds the ability to select SH/SE banks in the debugfs entry.

I know the existing amdgpu_gfx_select_se_sh only has SE and SH as the
name implies, but the GRBM_GFX_INDEX also has an instance field. It
would be good to account for that already, since this is defining a
somewhat public interface.

Nicolai

>
>
> In concert with the other patch I sent out this morning (the config
> debugfs entry) the debug tool can now select banks and sanity check user
> input.
>
>
> Tom
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160629/319a184b/attachment-0001.html>