[PATCH 3/3] drm/amd/amdgpu: Add bank selection for MMIO debugfs (v3)

[Michel Dänzer]

On 30.06.2016 01:37, StDenis, Tom wrote:
> It's my understanding that kmalloc allocates entire pages (and ideally
> contiguous ones) so it's a bit more precious.  From my experience on the
> embedded space that was definitely the case.  Trying to allocate [say]
> multiple 64KB chunks could result in failures in short order.
> 
> 
> Ultimately I'm not against either approach since the memory is so short
> lived and the function is not performance sensitive.  I'd just like to
> get these pushed today so I can get the debug updates pushed out too.
> 
> 
> If you'd (or anyone) will slap a RB on it with kmalloc I'll gladly
> change it :-)

FWIW, drm_calloc_large / drm_malloc_ab automatically use kmalloc or
vmalloc as appropriate. Memory allocated with them must be freed with
drm_free_large.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer