[PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

Christian König deathsimple at vodafone.de
Sun Oct 9 15:12:54 UTC 2016


Am 05.10.2016 um 21:42 schrieb Alex Deucher:
> Looks like fallout from a rebase or merge.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

NAK, this is done on purpose and is for evicting the GART table using 
memcpy.

Tom wanted to remove that as well and it makes resume then fail horrible 
on dGPUs.

We should probably add a comment why this is necessary.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 45259b5..c2f70be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool suspend, bool fbcon)
>   
>   	r = amdgpu_suspend(adev);
>   
> -	/* evict remaining vram memory */
> -	amdgpu_bo_evict_vram(adev);
> -
>   	pci_save_state(dev->pdev);
>   	if (suspend) {
>   		/* Shut down the device */




More information about the amd-gfx mailing list