[PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

[Tom St Denis]

I proposed to remove that when running into SDMA job out-of-order issues
and Christian K very strongly NAK'ed that (a couple of times).

So I suspect he'll do it again.

Tom


On Wed, Oct 5, 2016 at 8:10 PM Dave Airlie <airlied at gmail.com> wrote:

> On 6 October 2016 at 05:42, Alex Deucher <alexdeucher at gmail.com> wrote:
> > Looks like fallout from a rebase or merge.
>
> Nearly sure we do it twice on purpose, at least radeon does it as well.
>
> so NAK without a better explaination.
>
> Dave.
>
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index 45259b5..c2f70be 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -1956,9 +1956,6 @@ int amdgpu_device_suspend(struct drm_device *dev,
> bool suspend, bool fbcon)
> >
> >         r = amdgpu_suspend(adev);
> >
> > -       /* evict remaining vram memory */
> > -       amdgpu_bo_evict_vram(adev);
> > -
> >         pci_save_state(dev->pdev);
> >         if (suspend) {
> >                 /* Shut down the device */
> > --
> > 2.5.5
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161006/038e60bc/attachment.html>