[PATCH] drm/amdgpu/si/dpm: fix swapped ck enable

StDenis, Tom Tom.StDenis at amd.com
Wed Sep 14 13:56:54 UTC 2016


Yup, that looks better.  My apologies.  Guess that's the downside of having assertions for enable and disable in the same driver.


Reviewed-by: Tom St Denis <tom.stdenis at amd.com>


________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher at gmail.com>
Sent: Wednesday, September 14, 2016 09:47
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/si/dpm: fix swapped ck enable

Fixes a regression in:
drm/amd/amdgpu: Tidy up SI SMC code

bug:
https://bugs.freedesktop.org/show_bug.cgi?id=97801

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/si_smc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/si_smc.c b/drivers/gpu/drm/amd/amdgpu/si_smc.c
index 2cc628c..47bbb40 100644
--- a/drivers/gpu/drm/amd/amdgpu/si_smc.c
+++ b/drivers/gpu/drm/amd/amdgpu/si_smc.c
@@ -143,9 +143,9 @@ void si_smc_clock(struct amdgpu_device *adev, bool enable)
         u32 tmp = RREG32_SMC(SMC_SYSCON_CLOCK_CNTL_0);

         if (enable)
-               tmp |= CK_DISABLE;
-       else
                 tmp &= ~CK_DISABLE;
+       else
+               tmp |= CK_DISABLE;

         WREG32_SMC(SMC_SYSCON_CLOCK_CNTL_0, tmp);
 }
--
2.5.5

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160914/d9377196/attachment.html>


More information about the amd-gfx mailing list