Topaz mistakenly reported as vf

[Deucher, Alexander]

Please make sure we only check that register on asics where it is relevant.  There are a bunch of VI asics.  It should probably be restricted to tonga and fiji only.


Alex


________________________________
From: Yu, Xiangliang
Sent: Tuesday, December 19, 2017 2:44 AM
To: José Pekkarinen
Cc: amd-gfx at lists.freedesktop.org; Deucher, Alexander; Koenig, Christian
Subject: RE: Topaz mistakenly reported as vf

We can add ASIC check in vi_detect_hw_virtualization function to avoid to entry error path.
I'll submit patch later.

Thanks!

> -----Original Message-----
> From: José Pekkarinen [mailto:jose.pekkarinen at canonical.com]
> Sent: Tuesday, December 19, 2017 3:27 PM
> To: Yu, Xiangliang <Xiangliang.Yu at amd.com>
> Cc: amd-gfx at lists.freedesktop.org; Deucher, Alexander
> <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>
> Subject: Re: Topaz mistakenly reported as vf
>
> On Tuesday, 19 December 2017 09:19:02 EET Yu, Xiangliang wrote:
> > Topaz doesn't support SRIOV.
> >
>
>        Hi Xiangliang,
>
>        Allow me to ask for some attention, as I'm trying to say that given
> that Topaz is not having support, amdgpu_sriov_vf(adev) may return false
> and ignore the vi.c code path. Instead of it, it enters the code path and
> reaches the BUG_ON that states this is not supported.
>
>        Thanks for coming back!
>
>        José.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20171219/cd3aa4fe/attachment.html>