[PATCH 2/2] drm/amdgpu: Refactor flip into prepare submit and submit. (v2)

Christian König deathsimple at vodafone.de
Sat Jan 14 07:36:12 UTC 2017


Am 13.01.2017 um 19:26 schrieb Alex Deucher:
> From: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
>
> Make pflip atomic friendly. Split the fuinction into
> whatever can fail part and the actual flip submit part.
> Call the pre-submit function before atomic states
> are swapped so in case of error we can fail the
> IOCTL.
>
> v2:
> Update due to  target_vblank code change.
> Fix identetation.
> Change return type for amdgpu_crtc_submit_flip to void
>
> Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
> Reviewed-by Harry Wentland <harry.wentland at amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

The coding style on a couple of functions headers is incorrect, here for 
example:
> void amdgpu_crtc_cleanup_flip_ctx(
> 		struct amdgpu_flip_work *work,
> 		struct amdgpu_bo *new_abo)

That should look like:
> void amdgpu_crtc_cleanup_flip_ctx(struct amdgpu_flip_work *work,
>                                   struct amdgpu_bo *new_abo)

Regards,
Christian.


More information about the amd-gfx mailing list