[PATCH 1/2] drm/amdgpu: Switch error code when bo pin fails. (v3)

[Christian König]

Am 13.01.2017 um 19:26 schrieb Alex Deucher:
> From: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
>
> Switching to -ENOMEM resolves a hang in case the driver
> uses this function in atomic code path.
>
> v2: Update commit message.
> v3:
> Remove forcing -EINVAL in case of amdgpu_bo_pin fail
> since there is no apparent reason for not just passing
> through the the return value.
>
> Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> Reviewed-by Harry Wentland <harry.wentland at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>.

>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 48a3f67..4986340 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -189,7 +189,6 @@ int amdgpu_crtc_page_flip_target(struct drm_crtc *crtc,
>   
>   	r = amdgpu_bo_pin(new_abo, AMDGPU_GEM_DOMAIN_VRAM, &base);
>   	if (unlikely(r != 0)) {
> -		r = -EINVAL;
>   		DRM_ERROR("failed to pin new abo buffer before flip\n");
>   		goto unreserve;
>   	}