[PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

Christian König deathsimple at vodafone.de
Mon Jul 17 21:31:52 UTC 2017


Am 17.07.2017 um 23:30 schrieb Felix Kuehling:
> On 17-07-17 05:02 PM, Christian König wrote:
>> +	if (p->adev->asic_type < CHIP_VEGA10 ||
>> +	    nptes != AMDGPU_VM_PTE_COUNT(p->adev) ||
>> +	    p->func != amdgpu_vm_do_set_ptes ||
>> +	    !(flags & AMDGPU_PTE_VALID)) {
> Because of this condition, I think this still won't work correctly for
> cpu page table updates. p->func will be amdgpu_vm_cpu_set_ptes.

Good point.

This is totally untested anyway, because of lack of hardware access at 
the moment.

Just wanted to point you to the bits I've changed for testing it.

Christian.

>
> Regards,
>    Felix
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx




More information about the amd-gfx mailing list