[PATCH 2/2] drm/amdgpu: sanitize soc15_allowed_read_registers

[Christian König]

Am 24.03.2017 um 19:38 schrieb Alex Deucher:
> On Fri, Mar 24, 2017 at 11:09 AM, Christian König
> <deathsimple at vodafone.de> wrote:
>> From: Christian König <christian.koenig at amd.com>
>>
>> Disallow mmCC_RB_BACKEND_DISABLE, reading it can cause GRBM problems and the
>> same info is available cached as enabled_rb_pipes_mask.
> NACK.  We need to implement the caching anyway for sr-iov.  We can
> just port the cache changes over from VI.  Have you started looking at
> that yet?

Yeah, had that halve way implemented and then realized that the 
registers aren't used by userspace any more.

The only user was addrlib and even there it actually looks incorrect to me.

Ken already had that mostly fixed in libdrm, but somehow missed that 
one. Going to send out libdrm changes to not read from it as well.

Additional to that it is completely pointless to read the register again 
when the info query already has everything from it anyway.

Christian.

>
> Alex
>
>> Also remove duplicate mmCP_CPF_BUSY_STAT.
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/soc15.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
>> index 7e54d9dc..be0d47f 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
>> @@ -296,11 +296,9 @@ static struct amdgpu_allowed_register_entry soc15_allowed_read_registers[] = {
>>          { SOC15_REG_OFFSET(GC, 0, mmCP_CPF_BUSY_STAT), false},
>>          { SOC15_REG_OFFSET(GC, 0, mmCP_CPF_STALLED_STAT1), false},
>>          { SOC15_REG_OFFSET(GC, 0, mmCP_CPF_STATUS), false},
>> -       { SOC15_REG_OFFSET(GC, 0, mmCP_CPF_BUSY_STAT), false},
>>          { SOC15_REG_OFFSET(GC, 0, mmCP_CPC_STALLED_STAT1), false},
>>          { SOC15_REG_OFFSET(GC, 0, mmCP_CPC_STATUS), false},
>>          { SOC15_REG_OFFSET(GC, 0, mmGB_ADDR_CONFIG), false},
>> -       { SOC15_REG_OFFSET(GC, 0, mmCC_RB_BACKEND_DISABLE), false, true},
>>          { SOC15_REG_OFFSET(GC, 0, mmGC_USER_RB_BACKEND_DISABLE), false, true},
>>          { SOC15_REG_OFFSET(GC, 0, mmGB_BACKEND_MAP), false, false},
>>   };
>> --
>> 2.5.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx