[PATCH] drm: Harmonize CIK ASIC support in radeon and amdgpu (v2)

[Michel Dänzer]

On 20/05/17 03:55 AM, Felix Kuehling wrote:
> On 17-05-18 09:17 PM, Michel Dänzer wrote:
>> Obviously, out-of-tree module builds will have to continue doing what
>> they've been doing so far with kernels without your patch. I'm thinking
>> about making it easier for them with kernels which do have your patch.
>> At some point in the future, maybe the support for kernels without your
>> patch can be dropped entirely.
> 
> I think out-of-tree builds using the CONFIG_AMDGPU_CIK option of the
> target kernel is not safe. Hybrid should use its own option that is
> determined by what the hybrid stack supports (kernel and user mode).

Sure, that's not what I mean. I mean out-of-tree builds can use

 options radeon ci_support=0 si_support=0

e.g. in /etc/modprobe.d/amdgpu-dkms.conf to prefer amdgpu in a cleaner
way than by blacklisting radeon.


>>>> The default at this point should possibly still be for CIK GPUs to be
>>>> driven by radeon, even if CONFIG_DRM_AMDGPU_CIK is enabled;
>>> Alex and Christian seem to think otherwise.
>> FWIW, on my AMD notebook (HP EliteBook 725 G2, Kaveri), suspend/resume
>> with amdgpu results in a black screen (can reboot blindly); works fine
>> with radeon.
> 
> Has this problem been reported anywhere? Is anyone working on fixing it?
> If it's not reported, it will never be fixed.

You're right, I'll file a bug report.


Another issue is the lack of HDMI / DP audio support without DC. It
seems weird to change the default to amdgpu before there is feature parity.


Anyway, go ahead and land your latest series, you can have my

Acked-by: Michel Dänzer <michel.daenzer at amd.com>

for that. I'll propose some changes on top of that.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer