[PATCH 2/3] drm/amdgpu: Remove two ! operations in an if condition
Michel Dänzer
michel at daenzer.net
Wed May 31 03:09:22 UTC 2017
On 31/05/17 06:47 AM, Alex Xie wrote:
> Make the code easier to understand.
>
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 7a323f9..9fdeb82 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -680,9 +680,11 @@ bool amdgpu_vm_need_pipeline_sync(struct amdgpu_ring *ring,
>
> if (amdgpu_vm_had_gpu_reset(adev, id))
> return true;
> - if (!vm_flush_needed && !gds_switch_needed)
> +
> + if (vm_flush_needed || gds_switch_needed)
> + return true;
> + else
> return false;
This can be further simplified to
return vm_flush_needed || gds_switch_needed;
With that,
Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
More information about the amd-gfx
mailing list