[PATCH 2/3] drm/amdgpu: Remove two ! operations in an if condition

Christian K├Ânig deathsimple at vodafone.de
Wed May 31 06:59:53 UTC 2017


Am 30.05.2017 um 23:47 schrieb Alex Xie:
>   Make the code easier to understand.
>
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 7a323f9..9fdeb82 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -680,9 +680,11 @@ bool amdgpu_vm_need_pipeline_sync(struct amdgpu_ring *ring,
>   
>   	if (amdgpu_vm_had_gpu_reset(adev, id))
>   		return true;
> -	if (!vm_flush_needed && !gds_switch_needed)
> +
> +	if (vm_flush_needed || gds_switch_needed)
> +		return true;
> +	else
>   		return false;
> -	return true;

Actually that should even use the canonical form, e.g. something like 
"return vm_flush_needed || gds_switch_needed;".

Apart from that looks good to me,
Christian.

>   }
>   
>   /**




More information about the amd-gfx mailing list