global data in display/dc/dce/dce_abm.c

[Cyr, Aric]

Hi Dave,

Agreed, those should probably be per adapter. We'll take a look and fix them up. Thanks for pointing them out.

Regards,
Aric
________________________________
From: Wentland, Harry
Sent: Thursday, September 28, 2017 8:29:58 PM
To: Dave Airlie; amd-gfx mailing list; Cyr, Aric; Koo, Anthony
Subject: Re: global data in display/dc/dce/dce_abm.c

On 2017-09-28 08:24 PM, Dave Airlie wrote:
> On 29 September 2017 at 10:18, Dave Airlie <airlied at gmail.com> wrote:
>> Hi Harry,
>>
>> stored_backlight_registers is a global static struct in bss segment,
>> it should probably be per device.
>
> There is also cached_wait_loop_number in
> amd/display/dc/dce/dce_dmcu.c
>

Thanks for spotting these. We probably want to fix them up.

I think both are used for embedded panels only which is why we haven't
noticed this being a problem.

Aric, Anthony, thoughts? Can you provide a patch to fix these?

Harry

> Dave.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170929/d28544e2/attachment.html>