[PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20

[Deucher, Alexander]

vbios asic init will still work.  It will wait on the psp init so I'd suggest we just drop this patch to keep the code consistent.  There are also possibly some registers that are handled by vbios asic init rather than psp.


Alex

________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Feifei Xu <Feifei.Xu at amd.com>
Sent: Sunday, December 9, 2018 11:45:52 PM
To: amd-gfx at lists.freedesktop.org
Cc: Xu, Feifei
Subject: [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20

On vega20, the job of executing the ASIC_INIT table when posting card
is moved to psp. Skip the atombios's ASIC_INIT on vega20 when posting
card.

Change-Id: Id1d3c0a0d19296d5ed804de7edf5b09b8d38c0a5
Signed-off-by: Feifei Xu <Feifei.Xu at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f2bda76c8e05..310d4eb0536b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2513,8 +2513,9 @@ int amdgpu_device_init(struct amdgpu_device *adev,
         /* detect if we are with an SRIOV vbios */
         amdgpu_device_detect_sriov_bios(adev);

+    DRM_INFO("skip posting card using ASIC INIT table in vbios on vega20\n");
         /* Post card if necessary */
-       if (amdgpu_device_need_post(adev)) {
+       if ((adev->asic_type != CHIP_VEGA20) && amdgpu_device_need_post(adev)) {
                 if (!adev->bios) {
                         dev_err(adev->dev, "no vBIOS found\n");
                         r = -EINVAL;
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20181210/95a76f25/attachment-0001.html>