[PATCH] drm/amdgpu: WARN once if amdgpu_bo_unpin is called for an unpinned BO

[Deucher, Alexander]

Reviewed-by: Alex Deucher <alexander.deuche at amd.com>

________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Michel Dänzer <michel at daenzer.net>
Sent: Thursday, December 13, 2018 11:06:35 AM
To: amd-gfx at lists.freedesktop.org
Subject: [PATCH] drm/amdgpu: WARN once if amdgpu_bo_unpin is called for an unpinned BO

From: Michel Dänzer <michel.daenzer at amd.com>

It indicates a pin/unpin imbalance bug somewhere. While the bug isn't
necessarily in the call chain hitting this, it's at least one part
involved.

Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index fd271f9746a2..728e15e5d68a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -912,7 +912,7 @@ int amdgpu_bo_unpin(struct amdgpu_bo *bo)
         struct ttm_operation_ctx ctx = { false, false };
         int r, i;

-       if (!bo->pin_count) {
+       if (WARN_ON_ONCE(!bo->pin_count)) {
                 dev_warn(adev->dev, "%p unpin not necessary\n", bo);
                 return 0;
         }
--
2.20.0.rc2

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20181213/aa847845/attachment-0003.html>