[PATCH 21/22] dma-buf/reservation: shouldn't kfree staged when slot available

[Liu, Monk]

Sorry, this bug is hit after I fixed another bug ()
And the only thing I observe is we hit vmc page fault or sometime kernel oops, very random, so I finally ends up with 
Thinking to wild pointer issue and found this place looks incorrect

I don't have trace or something right now, but those weird issues gone after this patch applied in stress CTS test 

-----Original Message-----
From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of Chris Wilson
Sent: 2018年2月26日 18:19
To: Koenig, Christian <Christian.Koenig at amd.com>; Christian König <ckoenig.leichtzumerken at gmail.com>; Liu, Monk <Monk.Liu at amd.com>; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 21/22] dma-buf/reservation: shouldn't kfree staged when slot available

Quoting Christian König (2018-02-26 09:42:15)
> Well first of all you need to send that to dri-devel and even lkml, so 
> that Chris and others can take a look as well.
> 
> Second that patch doesn't looks correct to me, obj->staged should 
> never be related to obj->fence.

Concurred. I would suspect missing rcu protection around a reader to cause the implied kernel oops. If you are fixing a bug, please do include as much details about the bug as you can (stacktraces, observations etc) so that other people who may have hit something similar can see if this patch might fix their problem, or if they recognise the problem as caused by something else.
-Chris
_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx