[PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

Michel Dänzer michel at daenzer.net
Tue Feb 27 09:16:32 UTC 2018


On 2018-02-27 09:47 AM, Monk Liu wrote:
> otherwise DRM keep reporting complain on ATOMIC flags
> during kmd reloading
> 
> Change-Id: I835b96e6d61c7995bbd5dd5478d056671dde9192
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> index 1206301..2218416 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> @@ -345,7 +345,7 @@ int amdgpu_fbdev_init(struct amdgpu_device *adev)
>  	drm_fb_helper_single_add_all_connectors(&rfbdev->helper);
>  
>  	/* disable all the possible outputs/crtcs before entering KMS mode */
> -	if (!amdgpu_device_has_dc_support(adev))
> +	if (amdgpu_device_has_dc_support(adev))
>  		drm_helper_disable_unused_functions(adev->ddev);

This function definitely needs to be called without DC. *If* it also
needs to be called with DC (I'll leave that to the DC developers to
judge), just remove the conditional.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list