[PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

[Liu, Monk]

I'm not familiar with DC stuffs, I found without this patch DRM always reporting error like this:


[   89.783235] [drm] Found UVD firmware Version: 1.87 Family ID: 17
[   89.783285] [drm] PSP loading UVD firmware
[   89.784657] [drm] MM table gpu addr = 0xcfc000, cpu addr = 000000005ec858a9.
[   89.784883] [drm] Found VCE firmware Version: 53.45 Binary ID: 4
[   89.784936] [drm] PSP loading VCE firmware
[   89.928790] [drm] UVD and UVD ENC initialized successfully.
[   89.928972] [drm] VCE initialized successfully.
[   89.936514] [drm:drm_helper_disable_unused_functions [drm_kms_helper]] *ERROR* Called for atomic driver, this is not what you want.
[   89.958458] [drm] fb mappable at 0xE1200000
[   89.958460] [drm] vram apper at 0xE0000000
[   89.958461] [drm] size 9216000
[   89.958462] [drm] fb depth is 24
[   89.958463] [drm]    pitch is 7680




-----Original Message-----
From: Michel Dänzer [mailto:michel at daenzer.net] 
Sent: 2018年2月27日 17:17
To: Liu, Monk <Monk.Liu at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

On 2018-02-27 09:47 AM, Monk Liu wrote:
> otherwise DRM keep reporting complain on ATOMIC flags during kmd 
> reloading
> 
> Change-Id: I835b96e6d61c7995bbd5dd5478d056671dde9192
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> index 1206301..2218416 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> @@ -345,7 +345,7 @@ int amdgpu_fbdev_init(struct amdgpu_device *adev)
>  	drm_fb_helper_single_add_all_connectors(&rfbdev->helper);
>  
>  	/* disable all the possible outputs/crtcs before entering KMS mode */
> -	if (!amdgpu_device_has_dc_support(adev))
> +	if (amdgpu_device_has_dc_support(adev))
>  		drm_helper_disable_unused_functions(adev->ddev);

This function definitely needs to be called without DC. *If* it also needs to be called with DC (I'll leave that to the DC developers to judge), just remove the conditional.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer