[PATCH] drm/amdgpu:Fixed wrong emit frame size for enc

Christian König ckoenig.leichtzumerken at gmail.com
Tue Feb 27 15:14:17 UTC 2018


Oh, wait a second this is for the encode ring, isn't it? I only fixed 
the decode ring.

In this case the patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>

Regards,
Christian.

Am 27.02.2018 um 16:13 schrieb Christian König:
> You are using outdated code, that has already be fixed on 
> amd-staging-drm-next.
>
> Christian.
>
> Am 27.02.2018 um 16:06 schrieb James Zhu:
>> Emit frame size should match with corresponding function,
>> uvd_v6_0_enc_ring_emit_vm_flush has 5 amdgpu_ring_write
>>
>> Signed-off-by: James Zhu <James.Zhu at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> index a3e64e2..f26f515 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> @@ -1580,7 +1580,7 @@ static const struct amdgpu_ring_funcs 
>> uvd_v6_0_enc_ring_vm_funcs = {
>>       .set_wptr = uvd_v6_0_enc_ring_set_wptr,
>>       .emit_frame_size =
>>           4 + /* uvd_v6_0_enc_ring_emit_pipeline_sync */
>> -        6 + /* uvd_v6_0_enc_ring_emit_vm_flush */
>> +        5 + /* uvd_v6_0_enc_ring_emit_vm_flush */
>>           5 + 5 + /* uvd_v6_0_enc_ring_emit_fence x2 vm fence */
>>           1, /* uvd_v6_0_enc_ring_insert_end */
>>       .emit_ib_size = 5, /* uvd_v6_0_enc_ring_emit_ib */
>



More information about the amd-gfx mailing list