[PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature
Zhu, Rex
Rex.Zhu at amd.com
Wed Jan 17 05:18:02 UTC 2018
-----Original Message-----
From: Grazvydas Ignotas [mailto:notasas at gmail.com]
Sent: Wednesday, January 17, 2018 1:53 AM
To: Zhu, Rex
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature
On Tue, Jan 16, 2018 at 2:02 PM, Rex Zhu <Rex.Zhu at amd.com> wrote:
> when this bit was set on module load,
> driver will allow the user over/under gpu clock and voltage through
> sysfs.
>
> by default, this bit was not set.
>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> + if (hwmgr->feature_mask & PP_OVER_DRIVER_MASK)
>>PP_OVERDRIVE_MASK? I believe "overdrive" is a single word.
Yes, OverDrive as a power feature. So better change to PP_OVERDRIVE_MASK.
Thanks.
Best Regards
Rex
More information about the amd-gfx
mailing list