[PATCH v3] drm/amdgpu: update documentation for amdgpu_drv.c

[Christian König]

Mhm, double checking that I now knew why my memory fooled me: We use 0 
as infinite timeout in radeon.

Maybe we should change amdgpu to do the same and reject negative values.

Christian.

Am 05.07.2018 um 16:54 schrieb Christian König:
> Sounds like my memory fooled me, but we should document that as well.
>
> Christian.
>
> Am 05.07.2018 um 16:47 schrieb Jiang, Sonny:
>>
>> Change it to,
>>
>> Value 0 is invalidated, will be adjusted to 10000. Negative values 
>> mean 'infinite timeout' (MAX_JIFFY_OFFSET).
>>
>>
>> Thanks,
>>
>> Sonny
>>
>> ------------------------------------------------------------------------
>> *From:* Christian König <ckoenig.leichtzumerken at gmail.com>
>> *Sent:* Thursday, July 5, 2018 3:30:28 AM
>> *To:* Jiang, Sonny; amd-gfx at lists.freedesktop.org
>> *Subject:* Re: [PATCH v3] drm/amdgpu: update documentation for 
>> amdgpu_drv.c
>> Am 04.07.2018 um 20:20 schrieb Sonny Jiang:
>> > [SNIP]
>> >
>> > +/**
>> > + * DOC: lockup_timeout (int)
>> > + * Set GPU scheduler timeout value in ms. It must be > 0.  The 
>> default is 10000.
>> > + */
>> >   MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms > 0 
>> (default 10000)");
>> >   module_param_named(lockup_timeout, amdgpu_lockup_timeout, int, 0444);
>>
>> Actually the description here is incorrect, a value of 0 is handled as
>> infinite timeout IIRC. Please fix while at it.
>>
>> Apart from that the patch is Acked-by: Christian König
>> <christian.koenig at amd.com>.
>>
>> Christian.
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180705/63eba3c6/attachment-0001.html>