[PATCH] drm/amdgpu: disable page queue on Vega10 SR-IOV VF

Liu, Monk Monk.Liu at amd.com
Wed Nov 7 07:21:28 UTC 2018

Hi team

Why we need this page_queue in amdgpu ?  can anyone share something of its introduction to the kmd ?
According to my understanding , gpu-scheduler already have couple levels of priority for contexts/entities , thus the job page_queue supposed to do (should be mapping/unmapping/moving) is already good took care of by "KERNEL" priority entities, and all other context/entity SDMA jobs will be handled after "KERNEL" jobs ...

So there is no real benefit to introduce page_queue (also for rlc_queue) to amdgpu with the existence of priority aware gpu-scheduler ... unless we are going to remove the "KERNEL" priority and always do the mapping/unmapping in page_queue ...


-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Zhang, Jerry(Junwei)
Sent: Wednesday, November 7, 2018 1:26 PM
To: Huang, Trigger <Trigger.Huang at amd.com>; amd-gfx at lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Kuehling, Felix <Felix.Kuehling at amd.com>
Subject: Re: [PATCH] drm/amdgpu: disable page queue on Vega10 SR-IOV VF

On 11/7/18 1:15 PM, Trigger Huang wrote:
> Currently, SDMA page queue is not used under SR-IOV VF, and this queue 
> will cause ring test failure in amdgpu module reload case. So just disable it.
> Signed-off-by: Trigger Huang <Trigger.Huang at amd.com>

Looks we ran into several issues about it on vega.
kfd also disabled vega10 for development.(but not sure the detail issue for them)

Thus, we may disable it for vega10 as well?
any comment? Alex, Christian, Flex.

> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c 
> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index e39a09eb0f..4edc848 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -1451,7 +1451,9 @@ static int sdma_v4_0_early_init(void *handle)
>   		adev->sdma.has_page_queue = false;
>   	} else {
>   		adev->sdma.num_instances = 2;
> -		if (adev->asic_type != CHIP_VEGA20 &&
> +		if ((adev->asic_type == CHIP_VEGA10) && amdgpu_sriov_vf((adev)))
> +			adev->sdma.has_page_queue = false;
> +		else if (adev->asic_type != CHIP_VEGA20 &&
>   				adev->asic_type != CHIP_VEGA12)
>   			adev->sdma.has_page_queue = true;
>   	}

amd-gfx mailing list
amd-gfx at lists.freedesktop.org

More information about the amd-gfx mailing list