[PATCH 2/2] drm/amdgpu/sdma4: use page queue 1 for buffer funcs

Christian K├Ânig ckoenig.leichtzumerken at gmail.com
Thu Nov 8 08:00:42 UTC 2018


Am 07.11.18 um 18:29 schrieb Alex Deucher:
> Use page queue 0 rather than 1 to avoid contention with GPUVM
> updates using page queue 0.

Well NAK for two reasons:
1. VM updates are currently balanced between page queue 0 and 1.
2. I want to keep one paging queue reserved for fault processing in the 
long term.

Christian.

>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 4b5b47dd2f4c..44c16a5c5428 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2062,7 +2062,8 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
>   {
>   	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
>   	if (adev->sdma.has_page_queue)
> -		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
> +		/* use page queue 1 since page queue 0 will be used for VM updates */
> +		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
>   	else
>   		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
>   }



More information about the amd-gfx mailing list