[PATCH 2/2] drm/amdgpu/sdma4: use page queue 1 for buffer funcs

[Alex Deucher]

On Wed, Nov 7, 2018 at 9:11 PM Zhang, Jerry(Junwei) <Jerry.Zhang at amd.com> wrote:
>
> On 11/8/18 1:29 AM, Alex Deucher wrote:
> > Use page queue 0 rather than 1 to avoid contention with GPUVM
> > updates using page queue 0.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>
> A little confuse, I thought we were going to use page queue(in any
> instance) for PT update,
> gfx ring for general sdma jobs.
>
> Any missing?

Yes, you are right, I mis-read the code.  I'll drop this patch.

Alex

>
> Regards,
> Jerry
> > ---
> >   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> > index 4b5b47dd2f4c..44c16a5c5428 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> > @@ -2062,7 +2062,8 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
> >   {
> >       adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
> >       if (adev->sdma.has_page_queue)
> > -             adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
> > +             /* use page queue 1 since page queue 0 will be used for VM updates */
> > +             adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
> >       else
> >               adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
> >   }
>